fix(deliveroo): handle UK API type differences #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes JSON unmarshaling errors when using
ordercli deliveroo historywith UK accounts.Problem
The UK Deliveroo API returns different types than expected:
order_number: returned asint, model expectedstringtotal: returned asstring(e.g.,"19.64"), model expected*float64This caused errors like:
Changes
internal/deliveroo/model.go: ChangedOrderNumbertoint,Total/OriginalTotaltostringinternal/deliveroo/format.go: Updated Summary() to handle new typesinternal/deliveroo/format_test.go: Updated test fixturesTesting
Tested with a real UK Deliveroo account:
Fixes #2